On 22/03/14 04:23, Shin Sterneck wrote:

Hi James,

thanks!

For now I would like to suggest the following ports:

+ exfat related ports (exfat-utils and fuse-exfat)

+ freeradius (opensource radius server)

+ tacplus (opensource tacacs+ server)

+ networkmanager related packages (openvpn plugins)

+ kdeplasma-applets-plasma-nm

I would suggest this package to move to the kde4 port rather than contrib. It's the successor of the "kde-applet-networkmanagement" package already there. This will keep kde packages together.

If there is interest I would also add the following packages, but not now because I just started to use them and in my opinion not fully tested yet, but they work fine so far in case someone wants to use them now.

+ openconnect (opensource vpn client for cisco's AnyConnect ssl vpn platform)

+ networkmanager-openconnect

Before doing that, I'll check the versions and dependencies to make sure to cover the rules and make sure that things build properly.

Regards,

Shin
_______________________________________________
crux-contrib mailing list
crux-contrib@lists.crux.nu
http://lists.crux.nu/mailman/listinfo/crux-contrib

+1

But a few small things.

use-exfat missing dependency scons

exfat-utils:
Missing dependency scons
Not all lines are indented consistently either use a tab or say 4 spaces.
LINKFLAGS="${LDFLAGS} " extra space.
"$PKG/usr/man/man8" You don't really need to quote these lines.

freeradius shouldn't have to list libtool as a dependency as it's in core unless it links to it. (finddeps freeradius, finddeps can be found in prt-utils)

pdns extra space after pdns.rc )

-exec rm {} \;

While ok could be repalced with

-exec rm {} +

That will lower the number of rm commands by adding multiple files to each rm statement.

mkdir does not respect umask please use install -d, while mkdir will be fine with umask 022, some use a different umask and this makes a foot print mismatch.

I haven't done any testing on your ports but a visual inspection shows they are in good quality. Please test in a clean environment to see if any dependencies are missing and test with prtverify.

Regards Danny Rawlins
Romster @ Freenode