Hi Romster!

thanks for your feedback and suggestions!
I'll work on this during my long flight tomorrow to Germany ;-)

Regards,
Shin


On Sat, Mar 22, 2014 at 8:00 PM, <crux-contrib-request@lists.crux.nu> wrote:
Send crux-contrib mailing list submissions to
        crux-contrib@lists.crux.nu

To subscribe or unsubscribe via the World Wide Web, visit
        http://lists.crux.nu/mailman/listinfo/crux-contrib
or, via email, send a message with subject or body 'help' to
        crux-contrib-request@lists.crux.nu

You can reach the person managing the list at
        crux-contrib-owner@lists.crux.nu

When replying, please edit your Subject line so it is more specific
than "Re: Contents of crux-contrib digest..."


Today's Topics:

   1. Re: Request for contrib access (Shin Sterneck)
   2. Re: Request for contrib access (Danny Rawlins)


----------------------------------------------------------------------

Message: 1
Date: Sat, 22 Mar 2014 02:23:39 +0900
From: Shin Sterneck <shin@sterneck.asia>
Subject: Re: [crux-contrib] Request for contrib access
To: crux-contrib@lists.crux.nu
Message-ID:
        <CAMab15B_SsC0azkOqN9CW-4TGxYq3SWhRJ4P=zJezFR4CCEjAQ@mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"

Hi James,

thanks!

For now I would like to suggest the following ports:

+ exfat related ports (exfat-utils and fuse-exfat)
+ freeradius (opensource radius server)
+ tacplus (opensource tacacs+ server)
+ networkmanager related packages (openvpn plugins)

+ kdeplasma-applets-plasma-nm
I would suggest this package to move to the kde4 port rather than contrib.
It's the successor of the "kde-applet-networkmanagement" package already
there. This will keep kde packages together.

If there is interest I would also add the following packages, but not now
because I just started to use them and in my opinion not fully tested yet,
but they work fine so far in case someone wants to use them now.

+ openconnect (opensource vpn client for cisco's AnyConnect ssl vpn
platform)
+ networkmanager-openconnect

Before doing that, I'll check the versions and dependencies to make sure to
cover the rules and make sure that things build properly.

Regards,
Shin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.crux.nu/pipermail/crux-contrib/attachments/20140322/68d73c68/attachment-0001.html>

------------------------------

Message: 2
Date: Sat, 22 Mar 2014 15:39:49 +1100
From: Danny Rawlins <monster.romster@gmail.com>
Subject: Re: [crux-contrib] Request for contrib access
To: crux-contrib@lists.crux.nu
Message-ID: <532D1415.6020003@gmail.com>
Content-Type: text/plain; charset="iso-8859-1"

On 22/03/14 04:23, Shin Sterneck wrote:
> Hi James,
>
> thanks!
>
> For now I would like to suggest the following ports:
>
> + exfat related ports (exfat-utils and fuse-exfat)
> + freeradius (opensource radius server)
> + tacplus (opensource tacacs+ server)
> + networkmanager related packages (openvpn plugins)
>
> + kdeplasma-applets-plasma-nm
> I would suggest this package to move to the kde4 port rather than
> contrib. It's the successor of the "kde-applet-networkmanagement"
> package already there. This will keep kde packages together.
>
> If there is interest I would also add the following packages, but not
> now because I just started to use them and in my opinion not fully
> tested yet, but they work fine so far in case someone wants to use
> them now.
>
> + openconnect (opensource vpn client for cisco's AnyConnect ssl vpn
> platform)
> + networkmanager-openconnect
>
> Before doing that, I'll check the versions and dependencies to make
> sure to cover the rules and make sure that things build properly.
>
> Regards,
> Shin
>
>
> _______________________________________________
> crux-contrib mailing list
> crux-contrib@lists.crux.nu
> http://lists.crux.nu/mailman/listinfo/crux-contrib
+1

But a few small things.

use-exfat missing dependency scons

exfat-utils:
Missing dependency scons
Not all lines are indented consistently either use a tab or say 4 spaces.
LINKFLAGS="${LDFLAGS} " extra space.
"$PKG/usr/man/man8" You don't really need to quote these lines.

freeradius shouldn't have to list libtool as a dependency as it's in
core unless it links to it. (finddeps freeradius, finddeps can be found
in prt-utils)

pdns extra space after pdns.rc )


-exec rm {} \;

While ok could be repalced with

-exec rm {} +

That will lower the number of rm commands by adding multiple files to
each rm statement.

mkdir does not respect umask please use install -d, while mkdir will be
fine with umask 022, some use a different umask and this makes a foot
print mismatch.


I haven't done any testing on your ports but a visual inspection shows
they are in good quality. Please test in a clean environment to see if
any dependencies are missing and test with prtverify.

Regards Danny Rawlins
Romster @ Freenode


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.crux.nu/pipermail/crux-contrib/attachments/20140322/12fff2e7/attachment-0001.html>

------------------------------

_______________________________________________
crux-contrib mailing list
crux-contrib@lists.crux.nu
http://lists.crux.nu/mailman/listinfo/crux-contrib


End of crux-contrib Digest, Vol 44, Issue 4
*******************************************