[clc-devel] [CRUX] #61: httpup timeout may be a conf option
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: new Component: httpup | Modified: Sun Jan 22 12:17:45 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- I propose to make CURLOPT_TIMEOUT a configurable value. Patch below adds new option to httpup.conf: {{{ operation_timeout 300 # Timeout for operation - default is 30 }}} This makes the life of users with slow net connection - just like me - a lot easier :) -- Ticket URL: <http://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: assigned Component: httpup | Modified: Tue Jan 31 20:35:37 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- Changes (by jw): * status: new => assigned Comment: Definitely makes sense, thanks for the patch; I'll add it to the next release -- Ticket URL: <https://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: assigned Component: httpup | Modified: Thu Feb 23 15:24:57 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- Comment (by jw): Fixed in [752] and [753]. Also set the default timeout to 60s. P.S. Next time, please test the patch before submitting it :-) -- Ticket URL: <http://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: closed Component: httpup | Modified: Thu Feb 23 15:25:11 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- Changes (by jw): * resolution: => fixed * status: assigned => closed -- Ticket URL: <http://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: closed Component: httpup | Modified: Fri Feb 24 09:41:30 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- Comment (by anonymous): Well, have not tested it a lot, it's true :) However it works for me just fine. Thanks! -- Ticket URL: <http://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: closed Component: httpup | Modified: Fri Feb 24 11:13:08 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- Comment (by jw): Just for completeness: the code used to be: {{{ #!cpp string key = s.substr(0, 10); string val = stripWhiteSpace(s.substr(10)); ... } else if (s.substr(0, 17) == "operation_timeout") { config.operationTimeout = val; } }}} if httpup.conf contains {{{"operation_timeout 300"}}}, {{{val}}} in this case is {{{"timeout 300"}}} since {{{val}}} is the substring starting from position 10. Your {{{atol("timeout 300")}}} call would then silently fail; in my tests, it returned just zero, in which case httpup would pass 0 as timeout to curl, which in turn would use its default timeout of five minutes. So basically you build a binary configuration option (30s httpup default, or 300s curl default), no matter what value one sets in httpup.conf :-) -- Ticket URL: <https://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
#61: httpup timeout may be a conf option -------------------------+-------------------------------------------------- Id: 61 | Status: closed Component: httpup | Modified: Sat Feb 25 23:15:15 2006 Severity: enhancement | Milestone: Priority: normal | Version: Owner: jw | Reporter: centericq@ukr.net -------------------------+-------------------------------------------------- Comment (by centericq@ukr.net): OMFG! :D Actually, thanks for pointing me that Right Way! It was not a perfect experience in patching, as i see now. -- Ticket URL: <http://crux.nu/cgi-bin/trac.cgi/ticket/61> CRUX <http://crux.nu/> CRUX
participants (1)
-
CRUX