Ok, I just checked pidgin and it doesn't even use aspell directly, it uses gtkspell. In my opinion, if gtkspell is installed, pidgin's configure should automatically detect and enable the feature. Otherwise it should disable it and allow you to continue, just like with any other optional feature (ie: meanwhile), without even having to specify --disable-gtkspell. That is why in my opinion this should be reported as a bug or a possible improvement upstream. The code I showed you before is an example of how you could overcome this shortcoming while the developers improve it. It detects if the library is installed, and if not, it appends --disable-gtkspell to the configure line. That way you don't have to add gtkspell as a dependency, but at the same time it will be enabled if it was installed before compiling the port, just like it would happen if pidgin's configure would take care of this. It is not a way to allow users to choose the addition of the spelling function, and it is not a Gentoo style USE flag. Feel free to use it or not. Ultimately it is your port and you can't make everybody happy. If all you want is a personal opinion, here is mine: use --disable-gtkspell. Alan Bartłomiej Palmowski <rotwang@crux.org.pl> escribió:
The solution with detecting if aspell is available in the system during pkgmk was never preffered (it is in close relationship with gentoo use flags, makes pkgfile more complicated).
The pidgin buildsystem's behaviuour is correct, if the aspell is available then add support for the spell checking, if it isn't then die with error message. That's why it needs to be decided by the user not a scipt. Since I want to provide sane defaults for everyone using contrib/pidgin it needs to be decided whether we want spell check support or not.
2014-02-10 10:23 GMT+01:00 Danny Rawlins <monster.romster@gmail.com>:
On 10/02/14 07:10, James Mills wrote:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au>wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
That's exactly what i do every compile.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux