On Mon, Feb 10, 2014 at 8:55 PM, Bartłomiej Palmowski <rotwang@crux.org.pl>wrote:
The solution with detecting if aspell is available in the system during pkgmk was never preffered (it is in close relationship with gentoo use flags, makes pkgfile more complicated).
Correct. CRUX's pkgutils does not have the notion of "optional features" (i.e: Gentoo's USE fags). Further more this over complicated both packaging and maintenance as well as general user and installation of ports. I still feel that doing this kind of thing inside a Pkgfile goes against the grain of CRUX -- It is both easier and makes more sense to me to just simply ``prt-get edit pidgin`` and ``prt-get update pidgin -fr -if`` This has been the CRUX way for years I suspect :) (Been using CRUX since 2.0)
The pidgin buildsystem's behaviuour is correct, if the aspell is available then add support for the spell checking, if it isn't then die with error message. That's why it needs to be decided by the user not a scipt. Since I want to provide sane defaults for everyone using contrib/pidgin it needs to be decided whether we want spell check support or not.
That being said... This is "your" port and you are the "maintainer" the CRUX Pkgfile is flexible enough such that this is possible to do in a "sane" way. Perhaps we can come up with a "convention" as such. I feel adding USE flags (ala Gentoo) or --with-spelling flags (ala OS X Homebrew) would require much design, architecture and decision making of the COre CRUX Development Team and possibly contrib maintainers. My 2c worth -- Personally I would adopt for the OS X Homewbrew style of --with-spelling (Maintainer's choice). So you would: prt-get depinst pidgin --with-spelling NB: The extra options come after the port NBB: This adds a lot of complexity to prt-get and it's source code. cheers James James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au