Hi, I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times? No need to haul in another dependency :) cheers James James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski <rotwang@crux.org.pl>wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
pidgin port has --disable-aspell so it wont work without modifying this port 2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski <rotwang@crux.org.pl>wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
On 09/02/14 23:00, Bart?omiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au <mailto:prologic@shortcircuit.net.au>>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au <mailto:prologic@shortcircuit.net.au> W: prologic.shortcircuit.net.au <http://prologic.shortcircuit.net.au>
On Sun, Feb 9, 2014 at 8:29 PM, Bart?omiej Palmowski <rotwang@crux.org.pl <mailto:rotwang@crux.org.pl>> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu <mailto:CRUX@lists.crux.nu> http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu <mailto:CRUX@lists.crux.nu> http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
I'll say again. prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :) IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents. cheers James James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au>wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
Removing --disable-aspell explicitly adds a dependency to the aspell and friends, that means everyone using contrib/pidgin would have to install aspell. I guess we could patch configure to silently determine if dictionary support should be included or not. But this kind of decisions should be made by the user imho. @James we can't expect every user to maintain their own port versions (and effectively CRUX flavours), that's why we need sane defaults, and sane defaults doesn't mean "bare minimum". 2014-02-09 21:10 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au>wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
Actually we can and we do. Just look at crux.nu/portdb and the sheer no. of duplicates. Editing the port's Pkgfile is not a big burdne on users. You have to remember the types of users that want to and enjoy using CRUX are those that aren't afraid of a "little hard work". I don't think it's worthwhile patching the configure script in pidgin either because this adds even more maintenance. What happens when pidgin upstream changes their configure script? How do you keep the patch in sync? CRUX is about simplicity and ease of use. The two can sometimes be conflicting especially when you want to add more "ease of use" for the cost of added complexity for "little gain". cheers James James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au On Mon, Feb 10, 2014 at 6:45 AM, Bartłomiej Palmowski <rotwang@crux.org.pl>wrote:
Removing --disable-aspell explicitly adds a dependency to the aspell and friends, that means everyone using contrib/pidgin would have to install aspell. I guess we could patch configure to silently determine if dictionary support should be included or not. But this kind of decisions should be made by the user imho.
@James we can't expect every user to maintain their own port versions (and effectively CRUX flavours), that's why we need sane defaults, and sane defaults doesn't mean "bare minimum".
2014-02-09 21:10 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au
wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
Removing --disable-aspell explicitly adds a dependency to the aspell and friends, that means everyone using contrib/pidgin would have to install aspell. I guess we could patch configure to silently determine if dictionary support should be included or not. But this kind of decisions should be made by the user imho.
Normally the configure script would detect and enable features if available, this should be reported as a bug upstream. You could also detect if aspell is installed or not, and provide --disable- aspell if its not, for example: ... build() { # Detect if aspell is available if [ -f /usr/include/aspell.h ]; then aspell=y else aspell=n fi cd $name-$version ./configure \ --prefix=/usr \ "$([ $aspell = y ] || echo --disable-aspell)" ... I noticed you forcefully disable other things that are correctly detected and enabled by the configure script, such as meanwhile. This is in fact the reason why I created my own port for pidgin. Regards, Alan
On Mon, Feb 10, 2014 at 11:05 AM, Alan Mizrahi <alan+crux@mizrahi.com.ve>wrote:
Normally the configure script would detect and enable features if available, this should be reported as a bug upstream.
I completely agree. Whoever "cares" enough about this should report a bug upstream! This is kind of not our (CRUX) problem :)
You could also detect if aspell is installed or not, and provide --disable- aspell if its not, for example:
... build() { # Detect if aspell is available if [ -f /usr/include/aspell.h ]; then aspell=y else aspell=n fi
cd $name-$version ./configure \ --prefix=/usr \ "$([ $aspell = y ] || echo --disable-aspell)" ...
I don't personally like this as a solution because it overcomplicates the resulting Pkgfile and creates more work and effort for Maintainers... However kudos on your Bash skills :)
I noticed you forcefully disable other things that are correctly detected and enabled by the configure script, such as meanwhile. This is in fact the reason why I created my own port for pidgin.
Agreed. IHMO Maintainers of Ports __should not__ deliberately disable optional features that are automatically picked up by the respective build system (e.g: autoconf in this case) unless they __have a very good reason__. If I were you I'd ask for this "forced" --disable-meanwhile to be removed from the pidgin port :) But you'd have to file a issue on http://crux.nu/bugs/ or Email/Chat toe the Maintainer :) cheers James James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On 10/02/14 07:10, James Mills wrote:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au <mailto:prologic@shortcircuit.net.au> W: prologic.shortcircuit.net.au <http://prologic.shortcircuit.net.au>
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au <mailto:d.rawlins@datafast.net.au>> wrote:
On 09/02/14 23:00, Bart?omiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au <mailto:prologic@shortcircuit.net.au>>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au <mailto:prologic@shortcircuit.net.au> W: prologic.shortcircuit.net.au <http://prologic.shortcircuit.net.au>
On Sun, Feb 9, 2014 at 8:29 PM, Bart?omiej Palmowski <rotwang@crux.org.pl <mailto:rotwang@crux.org.pl>> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu <mailto:CRUX@lists.crux.nu> http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu <mailto:CRUX@lists.crux.nu> http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu <mailto:CRUX@lists.crux.nu> http://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu <mailto:CRUX@lists.crux.nu> http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux That's exactly what i do every compile.
The solution with detecting if aspell is available in the system during pkgmk was never preffered (it is in close relationship with gentoo use flags, makes pkgfile more complicated). The pidgin buildsystem's behaviuour is correct, if the aspell is available then add support for the spell checking, if it isn't then die with error message. That's why it needs to be decided by the user not a scipt. Since I want to provide sane defaults for everyone using contrib/pidgin it needs to be decided whether we want spell check support or not. 2014-02-10 10:23 GMT+01:00 Danny Rawlins <monster.romster@gmail.com>:
On 10/02/14 07:10, James Mills wrote:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au>wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
That's exactly what i do every compile.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
On Mon, Feb 10, 2014 at 8:55 PM, Bartłomiej Palmowski <rotwang@crux.org.pl>wrote:
The solution with detecting if aspell is available in the system during pkgmk was never preffered (it is in close relationship with gentoo use flags, makes pkgfile more complicated).
Correct. CRUX's pkgutils does not have the notion of "optional features" (i.e: Gentoo's USE fags). Further more this over complicated both packaging and maintenance as well as general user and installation of ports. I still feel that doing this kind of thing inside a Pkgfile goes against the grain of CRUX -- It is both easier and makes more sense to me to just simply ``prt-get edit pidgin`` and ``prt-get update pidgin -fr -if`` This has been the CRUX way for years I suspect :) (Been using CRUX since 2.0)
The pidgin buildsystem's behaviuour is correct, if the aspell is available then add support for the spell checking, if it isn't then die with error message. That's why it needs to be decided by the user not a scipt. Since I want to provide sane defaults for everyone using contrib/pidgin it needs to be decided whether we want spell check support or not.
That being said... This is "your" port and you are the "maintainer" the CRUX Pkgfile is flexible enough such that this is possible to do in a "sane" way. Perhaps we can come up with a "convention" as such. I feel adding USE flags (ala Gentoo) or --with-spelling flags (ala OS X Homebrew) would require much design, architecture and decision making of the COre CRUX Development Team and possibly contrib maintainers. My 2c worth -- Personally I would adopt for the OS X Homewbrew style of --with-spelling (Maintainer's choice). So you would: prt-get depinst pidgin --with-spelling NB: The extra options come after the port NBB: This adds a lot of complexity to prt-get and it's source code. cheers James James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
Ok, I just checked pidgin and it doesn't even use aspell directly, it uses gtkspell. In my opinion, if gtkspell is installed, pidgin's configure should automatically detect and enable the feature. Otherwise it should disable it and allow you to continue, just like with any other optional feature (ie: meanwhile), without even having to specify --disable-gtkspell. That is why in my opinion this should be reported as a bug or a possible improvement upstream. The code I showed you before is an example of how you could overcome this shortcoming while the developers improve it. It detects if the library is installed, and if not, it appends --disable-gtkspell to the configure line. That way you don't have to add gtkspell as a dependency, but at the same time it will be enabled if it was installed before compiling the port, just like it would happen if pidgin's configure would take care of this. It is not a way to allow users to choose the addition of the spelling function, and it is not a Gentoo style USE flag. Feel free to use it or not. Ultimately it is your port and you can't make everybody happy. If all you want is a personal opinion, here is mine: use --disable-gtkspell. Alan Bartłomiej Palmowski <rotwang@crux.org.pl> escribió:
The solution with detecting if aspell is available in the system during pkgmk was never preffered (it is in close relationship with gentoo use flags, makes pkgfile more complicated).
The pidgin buildsystem's behaviuour is correct, if the aspell is available then add support for the spell checking, if it isn't then die with error message. That's why it needs to be decided by the user not a scipt. Since I want to provide sane defaults for everyone using contrib/pidgin it needs to be decided whether we want spell check support or not.
2014-02-10 10:23 GMT+01:00 Danny Rawlins <monster.romster@gmail.com>:
On 10/02/14 07:10, James Mills wrote:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins <d.rawlins@datafast.net.au>wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://lists.crux.nu/mailman/listinfo/crux
That's exactly what i do every compile.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
As I said, finding if gtkspell is installed or not during pkgmk *isn't* preferred, all I want to do is provide *sane* defaults for most users. We can't expect that every user is going to maintain his list of ports, no one is going to remember (or should) that they should modify pidgin pkgfile between ports -u and prt-get sysup. I think that pidgin configure is correct because it enforces deliberate action whether to enable spell check or not. I could change that like I wanted without asking anyone (that's what I'm going to do in the future), but I've thought that it would be nice to listen if other people would like spell check support or not. 2014-02-10 16:09 GMT+01:00 Alan Mizrahi <alan+crux@mizrahi.com.ve>:
Ok, I just checked pidgin and it doesn't even use aspell directly, it uses gtkspell.
In my opinion, if gtkspell is installed, pidgin's configure should automatically detect and enable the feature. Otherwise it should disable it and allow you to continue, just like with any other optional feature (ie: meanwhile), without even having to specify --disable-gtkspell.
That is why in my opinion this should be reported as a bug or a possible improvement upstream.
The code I showed you before is an example of how you could overcome this shortcoming while the developers improve it. It detects if the library is installed, and if not, it appends --disable-gtkspell to the configure line. That way you don't have to add gtkspell as a dependency, but at the same time it will be enabled if it was installed before compiling the port, just like it would happen if pidgin's configure would take care of this. It is not a way to allow users to choose the addition of the spelling function, and it is not a Gentoo style USE flag.
Feel free to use it or not. Ultimately it is your port and you can't make everybody happy. If all you want is a personal opinion, here is mine: use --disable-gtkspell.
Alan
Bartłomiej Palmowski <rotwang@crux.org.pl> escribió:
The solution with detecting if aspell is available in the system during
pkgmk was never preffered (it is in close relationship with gentoo use flags, makes pkgfile more complicated).
The pidgin buildsystem's behaviuour is correct, if the aspell is available then add support for the spell checking, if it isn't then die with error message. That's why it needs to be decided by the user not a scipt. Since I want to provide sane defaults for everyone using contrib/pidgin it needs to be decided whether we want spell check support or not.
2014-02-10 10:23 GMT+01:00 Danny Rawlins <monster.romster@gmail.com>:
On 10/02/14 07:10, James Mills wrote:
I'll say again.
prt-get edit pidgin ... remove --disable-aspell prt-get depinst aspell prt-get update -fr pidgin
This is not hard guys. CRUX is not meant to "hand hold" you through every step of the process :) If you wanted a distro that does that there's Ubuntu, Arch, etc, etc :)
IHMO Ports have always been (unwritten rule?) the bare minimum for the functionality the software represents.
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 11:42 PM, Danny Rawlins < d.rawlins@datafast.net.au>wrote:
On 09/02/14 23:00, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
2014-02-09 12:06 GMT+01:00 James Mills <prologic@shortcircuit.net.au>:
Can't you just install aspell/ispell
and rebuild pidgin like I've done so many times?
No need to haul in another dependency :)
cheers James
James Mills / prologic
E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au
On Sun, Feb 9, 2014 at 8:29 PM, Bartłomiej Palmowski < rotwang@crux.org.pl> wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://l ists.crux.nu/mailman/listinfo/crux
I've manually removed that --disable-aspell line and recompiled. it be nice if the code was patched to be enabled if found or disabled if aspell was not found.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing listCRUX@lists.crux.nuhttp://l ists.crux.nu/mailman/listinfo/crux
That's exactly what i do every compile.
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
_______________________________________________ CRUX mailing list CRUX@lists.crux.nu http://lists.crux.nu/mailman/listinfo/crux
Hey, On 02/09/2014 01:00 PM, Bartłomiej Palmowski wrote:
pidgin port has --disable-aspell so it wont work without modifying this port
I think thats not true for contrib/pidgin, I do not see anywhere that '--disable-aspell' you said. http://crux.nu/gitweb/?p=ports/contrib.git;a=blob;f=pidgin/Pkgfile;h=b437ed9... Anyway, if pidgin autodetects aspell, where is the problem? So just write a README file with a note about aspell as a nice to have before build pidgin. I do not think it's necessary to have a super complex USE_FLAGS system as Gentoo. A Pkgfile and a README file are enough, don't forget the KISS principle. ATM, instead of force aspell, you could write a README file and put the steps to have pidgin with aspell support: - install aspell - rebuild pidgin - force footprint update (if changed due to aspell) ... Regards, -- Jose V Beneyto | http://sepen.it.cx/
On 02/09/2014 04:29 AM, Bartłomiej Palmowski wrote:
Hi,
I would like to know if any contrib/pidgin users would like to have aspell support. It would add aspell and friends to the list of dependencies.
While I have no strong preference myself, I for one appreciate that you considered other users before making the change. Regardless of the response, in my opinion you're free to do it the way you prefer. You are the maintainer and if someone else truly wants it done a different way they can fork it as before. Cheers, Matt
participants (7)
-
Alan Mizrahi -
Bartłomiej Palmowski -
Danny Rawlins -
Danny Rawlins -
James Mills -
Jose V Beneyto -
Matt Housh