prt-get prints logfile twice in dumpconfig
Hi, Looks like a copy-paste issue in commit 7c8a9b2ae5884cc8a15e31954768befdfd9442fe The same value (m_config->logFilePattern()) is already printed out several lines above (line 2130). diff --git a/src/prtget.cpp b/src/prtget.cpp index 3d9863f..f22214c 100644 --- a/src/prtget.cpp +++ b/src/prtget.cpp @@ -2142,7 +2142,7 @@ void PrtGet::dumpConfig() cout.setf( ios::left, ios::adjustfield ); cout.width( 20 ); cout.fill( ' ' ); - cout << "Pkgmk settings: " << m_config->logFilePattern() << endl; + cout << "Pkgmk settings:" << endl; cout.setf( ios::left, ios::adjustfield ); cout.width( 20 ); cout.fill( ' ' ); -- Vitaly Sinilin <vs@kp4.ru>
On Mon, Aug 01, 2016 at 02:18:22PM +0300, Vitaly Sinilin wrote:
Hi,
Hello Vitaly,
Looks like a copy-paste issue in commit 7c8a9b2ae5884cc8a15e31954768befdfd9442fe
The same value (m_config->logFilePattern()) is already printed out several lines above (line 2130).
prt-get is hosted by it's author on github now [1]. He is no longer active in the CRUX community, but I guess he will still accept pull requests for prt-get and httpup. Thanks and regards Juergen [1] https://github.com/winkj/prt-get
Hello Vitaly,
Hello Juergen. Thank you for your answer.
prt-get is hosted by it's author on github now [1]. He is no longer active in the CRUX community, but I guess he will still accept pull requests for prt-get and httpup.
Ok, I'll send him pull request on github, but apart from this small fix I have another topic for discussion that affects both prt-get and pkgutils and now I doubt what is the best place for such discussion. Could you advise on this? -- Vitaly Sinilin <vs@kp4.ru>
On Mon, Aug 01, 2016 at 04:26:48PM +0300, Vitaly Sinilin wrote:
Hello Vitaly,
Hello Juergen. Thank you for your answer.
prt-get is hosted by it's author on github now [1]. He is no longer active in the CRUX community, but I guess he will still accept pull requests for prt-get and httpup.
Ok, I'll send him pull request on github, but apart from this small fix I have another topic for discussion that affects both prt-get and pkgutils and now I doubt what is the best place for such discussion.
Could you advise on this?
I'd suggest to use the crux-devel mailinglist. Greetings Juergen
participants (2)
-
Juergen Daubert
-
Vitaly Sinilin