May 2008 - crux-devel - lists.crux.nu

[CRUX][#283] pkgmk, build from existing work dir
by CRUX 23 May '08

23 May '08

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. You have been assigned the following task: FS#283 - pkgmk, build from existing work dir User who did this - Bartlomiej Palmowski (mxq) More information can be found at the following URL: http://crux.nu/bugs/index.php?do=details&task_id=283 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[CRUX][#283] pkgmk, build from existing work dir
by CRUX 23 May '08

23 May '08

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Bartlomiej Palmowski (mxq) Attached to Project - CRUX Summary - pkgmk, build from existing work dir Task Type - Feature Request Category - pkgutils Status - New Assigned To - CRUX Developers Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - pkgmk build from existing work dir (would work well in conjunction with extract only #271), handy to check with the sources quickly modify then build, and then modify Pkgfile. It also gives a warning after succesful build and removes TARGET, just to be sure Pkgfile will be modified and checked. More information can be found at the following URL: http://crux.nu/bugs/index.php?do=details&task_id=283 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

pkgutils, pkgmk, build from existing work patch
by Bartek Palmowski 23 May '08

23 May '08

Hi (this is my first post here \:D/) Pkgmk deletes work dir before performing build, I think it would be very handy feature to optionally allow building package from existing work dir, it would work very well altogether with nipuL's pkgutils-5.32.0-extract-only.patch[1], instead of pkgmk -do, then extracting sources manually, then modifiing Pkgfile, making patches, and then checking if it works, it would be easier to do firstly pkgmk -do -e to download and extract sources, "mess" with them, and then pkgmk -b to build from already modified sources. It would speed up port creating and debugging process, and would be useful not only for port maintainers but also end users trying to tweak or simply make ports to work. You may think of it as similar to putting read KEY inside build(). Such feature is included in other distros' package builders i.e. "makepkg -e" etc. etc. Patch attached. Best regards Bartlomiej Palmowski 1 - http://article.gmane.org/gmane.linux.distributions.crux.general/2940 diff -pruN pkgutils-5.32.0.orig/pkgmk.in pkgutils-5.32.0/pkgmk.in --- pkgutils-5.32.0.orig/pkgmk.in 2008-03-01 10:18:03.000000000 +0100 +++ pkgutils-5.32.0/pkgmk.in 2008-05-22 21:59:50.000000000 +0200 @@ -339,8 +339,11 @@ build_package() { umask 022 cd $PKGMK_ROOT + + if [[ $PKGMK_BUILD = "no" ]] ; then rm -rf $PKGMK_WORK_DIR mkdir -p $SRC $PKG + fi if [ "$PKGMK_IGNORE_MD5SUM" = "no" ]; then check_md5sum @@ -352,7 +355,7 @@ build_package() { info "Building '$TARGET'." - unpack_source + [[ $PKGMK_BUILD = "yes" ]] || unpack_source cd $SRC (set -e -x ; build) @@ -508,6 +511,7 @@ print_help() { echo " -f, --force build package even if it appears to be up to date" echo " -c, --clean remove package and downloaded files" echo " -kw, --keep-work keep temporary working directory" + echo " -b --build build from existing work directory" echo " -cf, --config-file <file> use alternative configuration file" echo " -v, --version print version and exit " echo " -h, --help print help and exit" @@ -547,6 +551,8 @@ parse_options() { PKGMK_CLEAN="yes" ;; -kw|--keep-work) PKGMK_KEEP_WORK="yes" ;; + -b|--build) + PKGMK_BUILD="yes" ;; -cf|--config-file) if [ ! "$2" ]; then echo "`basename $PKGMK_COMMAND`: option $1 requires an argument" @@ -667,6 +673,7 @@ PKGMK_UPDATE_FOOTPRINT="no" PKGMK_IGNORE_FOOTPRINT="no" PKGMK_FORCE="no" PKGMK_KEEP_WORK="no" +PKGMK_BUILD="no" PKGMK_UPDATE_MD5SUM="no" PKGMK_IGNORE_MD5SUM="no" PKGMK_CHECK_MD5SUM="no"

6 5

prtverify daily results
by crux＠crux.nu 23 May '08

23 May '08

Differences since last check: (no differences) Full report: http://crux.nu/files/prtverify.log

1 0

Potentially broken source downloads
by crux＠crux.nu 23 May '08

23 May '08

Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/chrony Url: http://chrony.sunsite.dk/download/chrony-1.23.tar.gz Reason: curl: (7) couldn't connect to host State: New Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/imagemagick Url: ftp://ftp.imagemagick.org/pub/ImageMagick/ImageMagick-6.3.9-0.tar.bz2 Reason: curl: (19) Given file does not exist State: Reminder Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/libpcap Url: http://www.tcpdump.org/release/libpcap-0.9.8.tar.gz Reason: curl: (7) couldn't connect to host State: Reminder Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/lsof Url: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_4.79.tar.bz2 Reason: curl: (19) Given file does not exist State: Changed reason Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/tcpdump Url: http://www.tcpdump.org/release/tcpdump-3.9.8.tar.gz Reason: curl: (7) couldn't connect to host State: Reminder Full report: http://crux.nu/files/check_urls.html

1 0

Re: [crux-devel] pkgutils, pkgmk, build from existing work, patch
by Bartek Palmowski 23 May '08

23 May '08

> Bartek Palmowski [2008-05-23 09:25]: >> > > > I wonder whether we can protect ourselves from releasing a port that >> > > > only worked because we messed with the srcdir directly :) >> > > > maybe we could make pkgmk _not_ create the final package if -b is used, >> > > > so you just get to see whether the build succeeded, but you'll only get >> > > > a package if you do _not_ use -b. >> > > > > > > Maintainer has a brain :D I personally count on that ;] > > Sure, but mistakes happen. Imagine you're testing a port late at night > or so ;D You've got some valid point here, modified patch attached, after succesful build it removes TARGET, and gives short warning. > Regards, > Tilman Bartek

1 0

Re: [crux-devel] pkgutils, pkgmk, build from existing work patch
by Bartek Palmowski 23 May '08

23 May '08

> I wonder whether we can protect ourselves from releasing a port that > only worked because we messed with the srcdir directly :) > maybe we could make pkgmk _not_ create the final package if -b is used, > so you just get to see whether the build succeeded, but you'll only get > a package if you do _not_ use -b. Maintainer has a brain :D I personally count on that ;] >Regards, >Tilman Bartek

2 1

Re: [crux-devel] pkgutils, pkgmk, build from existing work patch
by Bartek Palmowski 23 May '08

23 May '08

Johannes Winkelmann wrote: />/So you'd end up with a package you can't reproduce after the 'work' is >removed, because you didn't make patches from your changes. Seems like a >major step back, and nothing that should be actively encouraged. Pkgfile is the only "interface" to interact with building process, whats the point of doing all changes to Pkgfile then rebuild, do changes again, then rebuild again (note that source package gets extracted every time that happens. Lets look at the situation when maintainer 'A' tries to build some port, he needs to perform some "surgery" on the Makefile, to do that in usual method he needs to think of a sed lines or make a patch, put in on the Pkgfile, and then perform build only to notice that he made i.e stupid mistake. With the pkgmk -b feature he could do it quikly, and by _memorizing_ (im talking about minor changes) apply those modifications to Pkgfile, which would speed port developing process and make it easier. >Independent from your request, please note thta it's a common pattern >that new users come here and tell us "it would be easier" and "it would >speed up [things]" or "such feature is include in other distros". >There's some comment on the in the "Compared to other Linux >distributions" section of http://crux.nu/Main/About which you may want >to read. >HTH, Johannes In my opinion it's good feature not because it is implemented in other distros but because it is good feature as it is, and i wanted to emphasis it would be useful for both sides: maintainers and users. Bartek

2 1

prtverify daily results
by crux＠crux.nu 22 May '08

22 May '08

Differences since last check: (no differences) Full report: http://crux.nu/files/prtverify.log

1 0

Potentially broken source downloads
by crux＠crux.nu 22 May '08

22 May '08

Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/lsof Url: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_4.79.tar.bz2 Reason: curl: (8) This doesn't seem like a nice ftp-server response State: Changed reason Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/mathopd Url: http://www.mathopd.org/dist/mathopd-1.5p6.tar.gz Reason: curl: (7) couldn't connect to host State: New Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/mathopd Url: http://www.mathopd.org/doc/mathopd.8.gz Reason: curl: (7) couldn't connect to host State: New Port: /home/crux/git-to-rsync-working-copy/crux-2.4/opt/mathopd Url: http://www.mathopd.org/doc/mathopd.conf.5.gz Reason: curl: (7) couldn't connect to host State: New Full report: http://crux.nu/files/check_urls.html

1 0